Skip to content

hal: renesas: ra: modify BSP_PLACE_IN_SECTION to .ramfunc section #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

hal: renesas: ra: modify BSP_PLACE_IN_SECTION to .ramfunc section #126

merged 1 commit into from
Aug 18, 2025

Conversation

@khoa-nguyen-18
Copy link
Contributor

@khoa-nguyen-18 khoa-nguyen-18 commented Aug 15, 2025 •
edited
Loading

Referring to r_flash_hp #64
Since in Zephyr, we does not define the .ram_from_flash section, we use the .ramfunc section, which has the same functional definition for r_flash_lp.
Detail information: #64 (comment)

@khoa-nguyen-18
Copy link
Contributor Author

khoa-nguyen-18 commented Aug 15, 2025

hi @KhiemNguyenT, could you please have a look at this PR?

@KhiemNguyenT KhiemNguyenT self-requested a review August 15, 2025 04:20
@KhiemNguyenT KhiemNguyenT self-assigned this Aug 15, 2025
@KhiemNguyenT
Copy link
Collaborator

KhiemNguyenT commented Aug 15, 2025

@khoa-nguyen-18 why is that change necessary ?

@khoa-nguyen-18
Copy link
Contributor Author

khoa-nguyen-18 commented Aug 15, 2025 •
edited
Loading

@khoa-nguyen-18 why is that change necessary ?

I changed this by referring to r_flash_hp #64. Since in Zephyr, we does not define the .ram_from_flash section, we use the .ramfunc section, which has the same functional definition for r_flash_lp.

@KhiemNguyenT
Copy link
Collaborator

KhiemNguyenT commented Aug 15, 2025

@khoa-nguyen-18 next times, please make sure to mention the rationale/purpose of the patch.
And please update the README file, similar with the change in PR #64.

@khoa-nguyen-18
hal: renesas: ra: modify BSP_PLACE_IN_SECTION to .ramfunc section
79962d7 
Move the place to store bsp from .ram_from_flash section to .ramfunc
for r_flash_lp

Signed-off-by: Khoa Nguyen <[email protected]>
@khoa-nguyen-18 khoa-nguyen-18 force-pushed the support_renesas_ra4_flash branch from 5320676 to 79962d7 Compare August 15, 2025 06:38
@khoa-nguyen-18
Copy link
Contributor Author

khoa-nguyen-18 commented Aug 15, 2025

@khoa-nguyen-18 next times, please make sure to mention the rationale/purpose of the patch. And please update the README file, similar with the change in PR #64.

Thank you, I have updated the README file.
Apologies for missing the rationale in this patch. I’ll make sure to include the rationale and purpose in future PR

@KhiemNguyenT KhiemNguyenT merged commit 0cdd997 into zephyrproject-rtos:main Aug 18, 2025
@khoa-nguyen-18 khoa-nguyen-18 deleted the support_renesas_ra4_flash branch August 18, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@thaoluonguw thaoluonguw thaoluonguw approved these changes

@duynguyenxa duynguyenxa duynguyenxa approved these changes

Assignees

@KhiemNguyenT KhiemNguyenT

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@khoa-nguyen-18 @KhiemNguyenT @thaoluonguw @duynguyenxa